Thanks much Daniel,

I'll get to work on your suggestions and attach a new copy of the port when I've finished. Thanks again.

Thanks,

Andrew Klettke
Optic Fusion NOC
253-830-2943



Daniel Dickman wrote:
Hi Andrew, here's some quick feedback to get you started...

1) Don't include the CVS directories in the tar.gz file.

2) See some small changes below for the Makefile. Also, does this package have regression tests? If so, you should set those up. If not, don't forget to include "NO_REGRESS=Yes" in the Makefile.

3) For pkg/DESCR, you need to make sure it's less than about 80 columns. Quick way to get something reasonable would be to use fmt(1). i.e. --
        fmt DESCR > DESCR.new
        mv DESCR.new DESCR

4) As for what you've put in the MESSAGE, you may want to take a look at ports that make use of @newgroup and @newuser in their PLISTs. Also see pkg_create(1).


--------------------------------------


# $OpenBSD: Makefile,v1.0 2009/12/18 14:09:20 aklettke Exp $

COMMENT =       The Internic referral whois server
DISTNAME =      rwhoisd-1.5.9.6
PKGNAME =       ${DISTNAME}p1

---> Remove the PKGNAME line. Why do you have this?

CATEGORIES =    net

HOMEPAGE=       http://projects.arin.net/rwhois/
MAINTAINER=     Andrew Klettke <aklet...@opticfusion.net>

WANTLIB =       c

MASTER_SITES=   ${HOMEPAGE}/ftp/

# GPLv2
PERMIT_PACKAGE_CDROM=   Yes
PERMIT_PACKAGE_FTP=     Yes
PERMIT_DISTFILES_CDROM= Yes
PERMIT_DISTFILES_FTP=   Yes

PREFIX=                 /usr/local
EPREFIX=                /usr/local

---> Why do you have the PREFIX and EPREFIX lines? I don't see any reason for them.
---> PREFIX is automatically set properly by the ports system.

USE_GMAKE=              Yes
CONFIGURE_STYLE=        gnu

do-install:
        ${INSTALL_PROGRAM} ${WRKBUILD}/server/rwhoisd ${PREFIX}/sbin/
.for i in rwhois_deleter rwhois_indexer rwhois_repack
        ${INSTALL_PROGRAM} ${WRKBUILD}/tools/$i/$i ${PREFIX}/bin/
.endfor

post-install:
        ${INSTALL_DATA_DIR} ${PREFIX}/share/doc/rwhoisd
        ${INSTALL_DATA_DIR} ${PREFIX}/share/examples/rwhoisd
.for i in LICENSE README VERSION
        ${INSTALL_DATA} ${WRKBUILD}/$i ${PREFIX}/share/doc/rwhoisd/
.endfor
        ${INSTALL_DATA} ${WRKBUILD}/doc/operations_guide.txt 
${WRKBUILD}/doc/security.txt ${PREFIX}/share/doc/rwhoisd/
        cp -R ${WRKBUILD}/sample.data/* ${PREFIX}/share/examples/rwhoisd/
        ${INSTALL_MAN} ${WRKBUILD}/doc/rwhoisd.8 ${PREFIX}/man/man8/
        ${INSTALL_MAN} ${WRKBUILD}/doc/rwhois_indexer.8 ${PREFIX}/man/man8/



.include <bsd.port.mk>


Reply via email to