On Fri, Aug 28, 2009 at 05:47:31PM +0100, Edd Barrett wrote: > Hi, > > Heres my next patch, hopefully with fewer niggly errors. If you are > going to be working on this, be careful with update-patches, as theres a > SUBST_CMD on a patch. > > On Thu, Aug 27, 2009 at 01:09:43AM +0000, Jacob Meuser wrote: > > On Wed, Aug 26, 2009 at 08:16:34PM +0100, Edd Barrett wrote: > > > > > +WANTLIB= c crypto m ncurses oil-0.3 pthread stdc++ util sndio \ > > > + z pthread-stubs xcb > > > > shouldn't pthread-stubs and xcb be part of the !no_x11 wantlibs? > > Correct. > > > > > + --enable-faac \ > > > +CONFIGURE_ENV+= LDFLAGS="-lfaac" > > > > are you sure this is needed after fixing the configure check? > > Apparently it is needed for the build, but not for the configure. So yes.
I'd rather fix the configure script to detect libfaac properly. can you send me the configure.log from where it's failing? > > you should really just remove the -O4, not add -O2 in it's place. > > Done > > > minor nit: the rest of the code uses foo( bar ) style spacing. > > Done > > > did anyone test recording from a bktr(4)? this "driver" should be > > really converted to using the new ai streams framework ... > > Anyone? > > > you should remove the @comment for gmplayer. I accidently left that > > in a patch I had sent. > > Done > > Also fixed hard coded /usr/local/ > > I notice GGI is broken on my sparc64 atleast. Does it work for you guys? > I get a seg when using `-vo ggi`. > > This is the longest thread ever... heh -- jake...@sdf.lonestar.org SDF Public Access UNIX System - http://sdf.lonestar.org
