On Mon, Aug 17, 2009 at 05:13:14PM +0200, Azwaw OUSADOU wrote: > Le Monday 17 August 2009 16:43:20 Stuart Henderson, vous avez écrit : > > On 2009/08/17 15:35, Azwaw OUSADOU wrote: > > > Le Sunday 16 August 2009 20:01:41, vous avez écrit : > > > > Hi, > > > > > > > > I updated openobex and obexftp to new version. I tested it and it's > > > > work fine with my Nokia N72, with my Nokia N95 disconnect failed. I can > > > > do only one operation. With obex you can saw data stocked in the > > > > internal memory of your phone. If you a have a old symbian (S60v1 and > > > > S60v2). You can get data in your memory card only with obex protocol. > > > > > > > > To work fine it's required a patch to libusb: > > > > > > > > With this patch usb_get_string get first the string descriptor (4 > > > > chars) and if it's ok, the requested string. It's required by some > > > > device (like Nokia N70/N72). > > > > > > > > Tested ok in i386. > > > > > > > > BSDManiak > > > > > > PATCH: > > > > your diff is mangled (spaces->tabs and quoted-printable mangling). > > would be nice to clean out the removals of the CVS control files too > > (-x CVS). > > http://ultragames93.free.fr/libusb.diff
Did you check that other apps using libusb weren't impacted by this patch ? Also, i don't think we want enable-debug=yes in ports.. And it's generally nice to add a comment on top of each patch saying what is modified and why, in particular in those weird corner cases. > http://ultragames93.free.fr/openobex.diff Same comment applies... so many patches, we don't know why/what things are fixed, where does the patch come from ? freebsd, upstream scm, you ? > http://ultragames93.free.fr/obexftp.diff Ditto.. what's this new patch for apps/obexftp.c, what does it fix ? And for the SHARED_LIBS, we usually don't follow upstream numbering, but that's a minor nit. Other than that, i don't really know how to use it with my N85, which shows as regular umass when configured as UMS (and mounts fine) : umass0 at uhub0 port 2 configuration 1 interface 0 "Nokia N85" rev 2.00/1.00 addr 2 umass0: using SCSI over Bulk-Only scsibus2 at umass0: 2 targets, initiator 0 sd0 at scsibus2 targ 1 lun 0: <Nokia, S60, 1.0> SCSI0 0/direct removable sd0: 7566MB, 512 bytes/sec, 15495168 sec total or shows as umodem when configured as 'pc suite' mode : umodem0 at uhub0 port 2 configuration 1 interface 1 "Nokia N85" rev 2.00/1.00 addr 2 umodem0: data interface 2, has no CM over data, has break umodem0: status change notification available ucom0 at umodem0 are we supposed to use irda or bluetooth to connect to it ? what's a standard commandline ? using obexftp -l -t /dev/cuaU0 when configured as ucom0, it fails. obexftp -u fails too. Landry
