On Sat, Jan 31, 2009 at 11:47:30PM -0600, Will Maier wrote: > Hi Ryan- > > On Sat, Jan 31, 2009 at 04:39:54PM -0800, Ryan Boggs wrote: > > I saw someone post the diffs to 1.0.0 a while back but it doesn't > > look like the port was ever updated. Since it looks like it was > > updated to 1.0.2, I thought I would give it a try. > > Thanks for the diff. Have you contacted the maintainer? Diffs like > this should always go to the maintainer first, especially because > they know the port (and the ports infrastructure in general).
I'm the maintainer, and I see the diff here now at least ;-)
> Either way, some comments on the diff:
>
> * The point of MODPY_EGG_VERSION is to keep PLIST updates clean.
> In this case, MODPY_EGG_VERSION should probably be
> 1.0.2-final.
> * Since MODPY_EGG_VERSION needs -final, PKGNAME should probably
> become py-${LNAME}-${V}
> * Were all the docs really collapsed into content.txt?
>
> The last step is testing. Have you been able to test this update at
> all?
Ryan, I was stuck on the 1.0.0 update due to a nasty crash that needed
some time and I haven't been back to it. Were you able to run 1.0.2
successfully with your diffs?
--
Darrin Chandler | Phoenix BSD User Group | MetaBUG
dwchand...@stilyagin.com | http://phxbug.org/ | http://metabug.org/
http://www.stilyagin.com/ | Daemons in the Desert | Global BUG Federation
pgpncN5B3SBAv.pgp
Description: PGP signature
