On Sun, Dec 21, 2008 at 11:52:45PM +0100, Gabri Mate wrote:
> On 19:12 Thu 04 Dec     , Gabri Mate wrote:
> > Dear Devs,
> > 
> > now that the ports tree is unlocked please test my port and commit it if
> > possible. I'd like to give you any help you need.
> > 
> > -- 
> > Gabri Mate
> > gabrim...@ippimail.com
> 
> Really is no one interested in getting this stuff into the ports tree?

I don't work on www/ ports, but a few details :

- no quotes in COMMENT
- please use fmt -w72 for DESCR/MESSAGE
- i don't think installing in postfixadmin-x.y.z and telling the user to
  manually symlink htdocs/postfixadmin to it is nice
- Makefile lacks licence comment (#GPLv2)
- in the meantime, 2.2.0 version has been released
- patches/patch-config.inc.php.sample is weird.. is there a reason to
  replace localhost by 127.0.0.1 ? generally, webapps chrooted under
/var/www already require a valid etc/hosts in the chroot...
- patches/postfixadmin-2.1.0-pgsql.patch is fugly. split it into several
  patches, or roll your own tarball to provide pgsql functionality.

Landry

Reply via email to