On Mon, Nov 10, 2008 at 12:01:48PM -0500, Jason Beaudoin wrote:
> Re Jasper's additions/cleanup:
>
> > DESCR should be in pkg/ and not in the top level directory.
>
> right, my mistake
>
> > further, i've cleaned up the port a fair bit, and the attached version
> > is what i intend to commit.
>
> great! I have a couple questions/comments, in an attempt at better
> understanding the process. I'd like to continue finding ways to
> contribute, I hope you don't mind my inquisitive nature here :)
>
> > some things i've changed:
> > - updated the port to the latest version
>
> I used the 3.4 series as I understand that the 3.5 (odd) series is the
> unstable track in glade's development:
> http://glade.gnome.org/todo.html
>
> It was also my understanding that, when given the opportunity, using
> the stable release was OpenBSD port's preferred route.
yep, but 3.5 is considered mature enough.
> > - added missing dependencies (gnome-doc-utils, desktop-file-utils, yelp)
>
> is the dependency for desktop-file-utils pulled in with: DESKTOP_FILES
> = Yes ?
indeed, please see x11/gnome/gnome.port.mk
> > - added missing PLIST goo (@exec/@unexec)
>
> are you referring to the last few lines of the PLIST file? I'm
> perplexed how I missed this, is there somewhere in the documentation
> that discusses this?
those lines indeed, and it's not fully documented (shame on me).
> > - start the shared library version at 0.0
>
> is the convention that the first number is openbsd's (internal)
> sharelib version, and the version given within the comment is external
> to the project, glade in this case?
the "convention" for new libraries is to start at 0.0, no matter the
version of the upstream project. later bumps go according to the rules
layed out in the docs.
> > - actually make use of gnome.port.mk
>
> I missed details about this, how is this done?
coming soon to a port-modules(5) on a mirror near you!
(for now, just use other ports as a reference.)
> > - no need for the AUTO*_VERSION variables
> > - add a missing configure argument (we take care of this with @exec in
> > PLIST)
>
> this confuses me..
>
> scrollkeeper is noted as build/run dependencies, though there is the
> --disable-scrollkeeper configure argument, and calls to exec in the
> PLIST. if you feel up to the task and have time to explain, I'm
> curious how this all works and what I'm missing.
the configure argument (--disable-scrollkeeper) is to make sure the
build process doesn't try to build the scrollkeeper catalog during
install. as this will generate a whole bunch of files into /var (, which
will also trip systrace).
it's just easier to execute the command ourselves at the end of the
installation/removal (@exec/@unexec) and be able to control it.
> > - and some more minor cleaning.
>
> thanks! I ran though the make steps to build and test-run the package,
> all went well.
>
> > comments/oks?
> >
> > cheers,
> > jasper
cheers,
jasper
> > --
> > "Intelligence should guide our actions, but in harmony with the
> > texture of the situation at hand"
> > -- Francisco Varela
> >
>
> Regards,
> ~Jason
>
--
"Intelligence should guide our actions, but in harmony with the
texture of the situation at hand"
-- Francisco Varela
