On Tue, Oct 28, 2008 at 09:23:21PM +0000, Jacob Meuser wrote: > On Wed, Oct 29, 2008 at 02:31:03AM +0900, IWATA Ray wrote: > > Hi, > > > > This patch adds plugin for libsndio. > > > + # we link to libpthread just in case one of our plugins does > > + # in which case this is required to avoid problems on dlclose() > > +-AC_CHECK_LIB(pthread, pthread_kill) > > ++dnl AC_CHECK_LIB(pthread, pthread_kill) > > ++CFLAGS="$CFLAGS -pthread" > > please don't do that. it's fine for OpenBSD but we want these patches > to go upstream ...
I guess "don't do that" is a little harsh, sorry. please keep in mind that we want to get these backends integrated upstream and not have a bunch of patches and auto* dependencies in ports. so if you make a backend (which is appreciated!!!), please remember what parts are for OpenBSD and what parts are for libsndio to make it easier for upstream inclusion. -- [EMAIL PROTECTED] SDF Public Access UNIX System - http://sdf.lonestar.org
