This passes regression tests ok now, thanks for fixing that.

do_install in your Makefile is unused (it would actually be 
do-install i.e. s/_/-/, but the original distribution already
has an install target which seems to be reasonably ok).
Doesn't need to be there -> remove. :)

It's best to try and have things so 'make plist' produces an
acceptable file; I would either rm the .orig in post-install or
list in PLIST with @comment so re-running "make plist" doesn't
re-include it.

Also has the cat3f/man3f thing mentioned before.

I need to go to another machine to actually try running it,
maybe tomorrow (need to go there to test X fixes too).

> # GPL
> PERMIT_PACKAGE_CDROM=   Yes
> PERMIT_PACKAGE_FTP=     Yes
> PERMIT_DISTFILES_CDROM= No
> PERMIT_DISTFILES_FTP=   Yes

PERMIT_DISTFILES_CDROM=No is pretty unusual for GPLv2 software,
is there a reason why? If so it should be shown in a comment.

If anyone is unsure about licensing/patents/etc, please point
it out and ask, it's super-important to get this right. It doesn't
apply here, but while I remember: for projects on sourceforge,
double-check the copyright statements and license in files in
the tarball, do not just go by the license marker on sf.net,
sometimes these markers are *WRONG*.

Someone committing it would fix these things first, but
I think it helps to point them out rather than do them in
the background so hopefully a few ports@ readers will pick
up on the process. :-)

Reply via email to