[email protected] wrote:
Hi,
As far as I understand, the recent pledge/unveil commits in i2pd are mostly
pointless (doing almost nothing), but also mostly harmless (introducing only
very minor regressions).
Andrew has submitted a pull request [1] and opened a discussion [2] on i2pd's
Github repo. I hope this will solve the problem. But we don't know if Andrew's
patches will be accepted upstream and how long it will take. In the meantime, I
would be in favor of updating the i2pd port anyway, as is.
I feel the same way. If we don't update it, we won't be able to identify
and fix any other regressions that arise.
On the one hand, this new version introduced 2 small regressions :
- MTU discovery for SSU2 packets doesn't work anymore
- i2pd doesn't run as a non-standard user or using non-standard file paths
Honestly, I don't know how serious the first issue is, but in all my tests,
i2pd continued to work fine with the default MTU.
The second issue is unlikely to affect most users. i2pd still runs fine when
launched with the provided rc script (ie. with 'rcctl start i2pd').
On the other hand, there are benefits to not delaying the update even more:
- versions 2.60.0 and 2.61.0 provide bug fixes and new features
- we would at last be able to move the port from using /var/lib/i2pd to /var/i2pd
("at last" because we're discussing this for months)
- and also to resolve other issues raised by David and Stuart
At least, provided we clearly inform users about the changes and known
regressions.
Re: the user intervention required by the move from /var/lib to /var, I agree with Stuart
that it's risky to try to automate that entirely. David, I appreciate your efforts, but
unfortunately your script is not enough to ensure a complete migration. As you know, the
_i2pd user has a new home directory, and in my tests, if this user is not recreated, i2pd
will somehow "insist" on writing files to the old directory (/var/lib/i2pd),
even with and updated configuration, and crash. Moreover, you're right that .dat files
must be moved to the new directory, but it's better if all other files are moved along
them (long story short, i2pd will run if other files are missing, but it'll lose
information about the network).
Please find attached a patch that updates i2pd to the latest release, with a
README explaining how to update the package and warning them about the small
regressions. Most of this patch is based on David's latest proposal. It applies
cleanly, with that the port builds and runs fine, with all tests passing.
My idea is that we'll be in a better position to incorporate or just even test
pledge/unveil changes after the port is updated.
Best regards.
