On Tue, Jul 14, 2026 at 05:10:10PM +0100, Stuart Henderson wrote:
> On 2026/07/14 17:02, Stuart Henderson wrote:
> > On 2026/07/14 10:45, izzy Meyer wrote:
> > > Sorry about that oversight. Here's a new diff with that added to
> > > LIB_DEPENDS. While we're here, I swapped devel and sysutils so sysutils
> > > is first in CATEGORY.
> > 
> > LIB_DEPENDS is wrong. There's no matching entry in WANTLIB (and there
> > shouldn't be) so the runtime dependency is stripped off, with this
> > warning
> > 
> > ===>  Building package for msitools-0.106p0
> > Create /usr/ports/packages/amd64/all/msitools-0.106p0.tgz
> > LIB_DEPENDS devel/gobject-introspection not needed for sysutils/msitools ?
> > Link to /usr/ports/packages/amd64/ftp/msitools-0.106p0.tgz
> > Link to /usr/ports/packages/amd64/ftp/debug-msitools-0.106p0.tgz
> > 
> > (I wish this was an actual error..)
> > 
> > This should be BUILD_DEPENDS + RUN_DEPENDS.

Actually it should only be BDEP.

> have committed with that
> 
> > > +CATEGORIES =     sysutils devel
> 
> (I kept that in alphabetical order)
> 
> > >  HOMEPAGE =       https://gitlab.gnome.org/GNOME/msitools
> > >  
> > > @@ -21,11 +22,13 @@ BUILD_DEPENDS = lang/vala,-main \
> > >           devel/bats
> > >  LIB_DEPENDS =    archivers/gcab \
> > >           devel/glib2 \
> > > +         devel/gobject-introspection \
> > >           devel/libgsf \
> > >           textproc/libxml
> > >  TEST_DEPENDS =   devel/bats \
> > >           sysutils/coreutils
> > >  
> > > +
> > >  SHARED_LIBS +=  msi-1.0                   0.0 # 0.0
> > >  
> > >  WANTLIB += c gcab-1.0 gio-2.0 glib-2.0 gobject-2.0 gsf-1 intl
> > 
> > > diff --git a/sysutils/msitools/Makefile b/sysutils/msitools/Makefile
> > > index e1e2c4451..933dfb7ec 100644
> > > --- a/sysutils/msitools/Makefile
> > > +++ b/sysutils/msitools/Makefile
> > > @@ -3,8 +3,9 @@ COMMENT = set of programs to build and inspect windows 
> > > installer files
> > >  V =              0.106
> > >  DIST_TUPLE +=    gnome GNOME msitools v${V} .
> > >  WRKDIST =        ${WRKDIR}/msitools-v${V}
> > > +REVISION =       0
> > >  
> > > -CATEGORIES =     devel sysutils
> > > +CATEGORIES =     sysutils devel
> > >  
> > >  HOMEPAGE =       https://gitlab.gnome.org/GNOME/msitools
> > >  
> > > @@ -21,11 +22,13 @@ BUILD_DEPENDS = lang/vala,-main \
> > >           devel/bats
> > >  LIB_DEPENDS =    archivers/gcab \
> > >           devel/glib2 \
> > > +         devel/gobject-introspection \
> > >           devel/libgsf \
> > >           textproc/libxml
> > >  TEST_DEPENDS =   devel/bats \
> > >           sysutils/coreutils
> > >  
> > > +
> > >  SHARED_LIBS +=  msi-1.0                   0.0 # 0.0
> > >  
> > >  WANTLIB += c gcab-1.0 gio-2.0 glib-2.0 gobject-2.0 gsf-1 intl
> > 
> 

-- 
Antoine

Reply via email to