Matthew writes: > Here is a WIP port of PCSX2 2.6.3. It runs well with the few games > I've tested on my machine (with Intel graphics) using OpenGL as the > renderer. Testers, tips, and corrections are appreciated.
Thanks for submitting this, and sorry it took so long for a response. Some comments: - Missing dep on graphics/shaderc. - USE_WXNEEDED and USE_NOBTCFI need a comment explaining what the problem is. And bug reports should be filed upstream so they know that there's interest in JITs that use branch target instructions and W^X memory. - This port would definitely benefit from enabling debug packages. - License marker should say "GPLv3 only" or "GPLv3+" rather than "GPLv3". Ditto for LGPLv3. - stdlib.h is the only header for malloc() and alloca() on Unix systems. The #ifdef blocks in pcsx2/GS/Renderers/HW/GSTextureCache.cpp and common/VectorIntrin.h should be replaced entirely upstream with just #include <stdlib.h>. - 3rdparty/rapidyaml/include/c4/yml/common.hpp should be upstreamed as: #if defined(C4_MSVC) || defined(C4_MINGW) || defined(_WIN32) || defined(C4_WIN) #include <malloc.h> #else #include <stdlib.h> #endif - pcsx2/Host/AudioStream.cpp seems wrong, /usr/local/include/soundtouch should be added to the include path with pkg-config. - Not really important, but please sort BUILD_DEPENDS and LIB_DEPENDS. I've built and started the program, but haven't tried any emulation. But overall the port looks good to me. > I am also attaching the update diff for emulators/libchdr and the > port for graphics/plutosvg that I sent before since they are needed > for this port. These have been committed.
