On 2007/11/16 15:24, Soner Tari wrote:
> On Thu, 2007-11-15 at 22:00 +0000, Stuart Henderson wrote:
> > On 2007/11/15 23:04, Soner Tari wrote:
> > > I've checked the other options like the one you are mentioning, but
> > > handling this in a separate shell script seems better to me (for example
> > > it's more readable and manageable in my opinion). Also note that I took
> > > postfix files as the basis for my p3scan-config. Therefore, if there is
> > > no harm, I'd like to keep p3scan-config.
> >
> > This is the wrong way to go, the pkg_* tools can handle this, so
> > let them. @exec is useful for cases where you can't use the normal
> > mechanisms, it's available but it should almost never be necessary.
> > You don't see it used very much in our ports tree.
> >
> > Postfix has to populate the chroot with files from the installed
> > system, and has its own mechanism to upgrade config files between
> > versions via /etc/postfix/post-install. This goes to make it a
> > bit of a special case... but even so, it does use the standard
> > @extra mechanism so that it doesn't break pkg_delete -c.
>
> Please find attached the last version based on your input. (My nice
> custom messages to the user are gone now, but anyway. Also, @sample
> cannot handle symlinks correctly, so I had to use @exec for it, hope
> that's ok.)
>
> Btw, net category is back, because the proxy software I see in the tree
> include net among their categories too, see pop3gwd for an example.
Thanks for incorporating that; I don't think there's a need to put
all the language versions of p3scan.mail into /etc/p3scan though;
wouldn't it be simpler to just
share/examples/p3scan/
@sample ${SYSCONFDIR}/p3scan/
share/examples/p3scan/p3scan-en.mail
@sample ${SYSCONFDIR}/p3scan/p3scan.mail
then don't @sample the rest; users can always copy the file from
examples if they'd like another language, and then there's no need
to worry about symlinks. (Actually you can install a symlink
under examples and then @sample that, but this way is cleaner).
Btw, please don't be disheartened by the backwards-and-forwards
tweaking things until they fit nicely; it can seem annoying at
times but, without it, the ports tree would be much less pleasant
to work with. It's hard work to keep things simple but I think
the results speak for themselves (-:
