the time_t fixes should cast the variable to (long long). not needed for OpenBSD but doesn't hurt, and needed if it's fed upstream for other os.

--
 Sent from a phone, apologies for poor formatting.

On 9 November 2025 14:27:48 Daniel Jakots <[email protected]> wrote:

Hey,

I now have a use for Sidekiq 8 which lists its requirements as:
Redis: Redis 7.0+, Valkey 7.2+ or Dragonfly 1.27+

I thought that would be the occasion to port valkey.

The port builds (I've yet to run it, I thought I would send it early).

Current issues:
- there were time_t warnings in the build, I'm not sure about the patch
 I did patch-src_valkey-check-aof_c
- there are warnings, but it seems we have the same in the redis port
- the PLIST lists some binary named 'redis-*', it seems on purpose, but
 I assume it makes redis and valkey conflicting. I guess we should
 remove the symlinks?
- an (early) test fails with "[exception]: Executing test client: ps:
/dev/mem: Permission denied."
- I haven't seen any mention is the release notes that could mean the
 upgrade from our redis 6.2.x is transparent, but I haven't tested it
 either

Attached the result of: /usr/ports/databases$ tar cvzf valkey.tgz valkey

It also needs:
Index: infrastructure/db/user.list
===================================================================
RCS file: /cvs/ports/infrastructure/db/user.list,v
retrieving revision 1.473
diff -u -p -r1.473 user.list
--- infrastructure/db/user.list 19 Oct 2025 16:23:20 -0000      1.473
+++ infrastructure/db/user.list 9 Nov 2025 14:09:43 -0000
@@ -84,7 +84,7 @@ id  user              group           port
573 _perdition          _perdition      mail/perdition
574 _siproxd            _siproxd        telephony/siproxd
575 _netflow            _netflow        net/flow-tools
-#576 _apache2          _apache2        www/apache-httpd
+576 _valkey            _valkey         databases/valkey
577 _openvpn            _openvpn        net/openvpn
578 _mrtg               _mrtg           net/mrtg
579 _hiawatha           _hiawatha       www/hiawatha


Any comments?

Cheers,
Daniel

Reply via email to