On 2025/10/26 21:57, Klemens Nanni wrote:
> 27.10.2025 00:21, Christian Weisgerber пишет:
> > David Leadbeater:
> > 
> >> I'm proposing a new port for trurl[1], a companion tool to curl for
> >> url manipulation.
> > 
> > Looks good.  Anybody else want to ok it before I import it?
> 
> - weird variable order / could match template more closely
> - needs python module
> - default extract_sufx
> - i'd do one assignment per line in fake_flags for readability
> - better fix shebang once before patches, not on every configure
> 
> With that OK kn

diff doesn't apply.

> diff --git net/trurl/Makefile net/trurl/Makefile
> index 637e5b47f..df316e3c4 100644
> --- net/trurl/Makefile
> +++ net/trurl/Makefile
> @@ -9,22 +9,31 @@ MAINTAINER= David Leadbeater <[email protected]>
>  # MIT
>  PERMIT_PACKAGE=      Yes
>  
> +WANTLIB=     c curl
> +
>  SITES=               https://curl.se/trurl/dl/
> -EXTRACT_SUFX=        .tar.gz
> +
> +MODULES=     lang/python
> +MODPY_BUILDDEP=      No
> +MODPY_RUNDEP=        No
>  
>  BUILD_DEPENDS=       shells/bash
> -TEST_DEPENDS=        lang/python/3

TEST_DEPENDS=   ${MODPY_RUN_DEPENDS}

> +
>  LIB_DEPENDS= net/curl
> -WANTLIB=     c curl
>  
>  USE_GMAKE=   Yes
> -ALL_TARGET=  all completions
> +CONFIGURE_STYLE= none
> +
>  # install target combines PREFIX and DISTDIR, this puts the files in the
>  # correct location.
>  FAKE_FLAGS=  PREFIX="${TRUEPREFIX}" \
>               MANDIR="${TRUEPREFIX}/man/man1"
>  
> -pre-configure:
> +TEST_FLAGS=  PYTHON3=${MODPY_BIN}
> +
> +ALL_TARGET=  all completions
> +
> +post-extract:
>       sed -i 's,/bin/bash,/usr/bin/env bash,' ${WRKSRC}/scripts/*.sh

as kirill says, ${LOCALBASE} probably better than env.

otherwise LGTM

Reply via email to