On 2007/10/05 11:35, Thomas Schoeller wrote:
> > CFLAGS= -O3
this overrides the user's chosen CFLAGS, which may include debug
settings, and we generally avoid -O above 2. if it's necessary
(e.g. inline assembly using a lot of registers) than +=O3 on
the arch that need it, otherwise it should just go.
> > PKGNAME= ${DISTNAME}
this can be removed, PKGNAME defaults to DISTNAME (it's usually
only used where you add p# and/or v#, or use a different PKGNAME
from DISTNAME)
> > .if ${MACHINE_ARCH} == "amd64"
> > CFLAGS= -O0
> > .endif
this should be += not = (the last -O value takes effect, overriding
any earlier setting from user's CFLAGS, this will then keep debug flags
working), it also needs a comment as to why it's been done so that it
can be tested against future C compiler versions and maybe removed.
can you send a diff -u with those in please? (I usually 'cvs diff -RuN'
against an anoncvs server or local mirrored repository, which includes the
version information, is easy to read and apply, and handles added/removed
files nicely, but any 'diff -u' would be good)
thanks!
