On Mon, May 19, 2025 at 01:25:29PM -0400, Thomas Frohwein wrote: > The port has been BROKEN for failing to launch, marked so since [1]. > Some testing showed that the server freeoriond crashes segfaults which > is probably the reason rather than the symbol size mismatch of > std::__1::allocator.
No, the comment is accurate. The port launched fine in my testing. Tom mentioned intermittent crashes. Why did it segfault for you? The size mismatch is worrying and it definitely can lead to crashes. > I'm attaching a diff that unbreaks the port by moving to HEAD from last > week. With this, the port launches again and runs without problems on > extended (singleplayer) sessions again. There is still the size > mismatch warning which I couldn't figure out. I tested switching all > CMAKE_CXX_STANDARD to 20, to no effect. Yes. > I versioned it as 0.5.1pl0 because we are using upstream from a version > more recent than 0.5.1. I also removed the patch for make_versioncpp.py > which failed to apply and doesn't seem needed - it fails to run git now > and then falls back to the hard-coded version number (v0.5.1+) which > doesn't affect the game adversely. > > As a bonus, this commit also makes provisions for Boost 1.88, hopefully > indicating less (or no) pain with the next Boost update. > > ok to unbreak? I won't object since it's just a game, so I don't really care, but I'm not convinced.
