I think that's ok (and way less invasive than the openal one, and
unlocks some ports which might actually be useful on sparc64..)

On 2025/04/29 16:32, Kirill A. Korinsky wrote:
> On Sun, 27 Apr 2025 09:16:58 +0200,
> Kurt Mosiejczuk <k...@cranky.work> wrote:
> > 
> > https://cranky.work/sparc64/2025-04-23/multimedia/libheif.log
> > 
> > heif_enc.cc:(.text+0x2508): undefined reference to 
> > `std::filesystem::__cxx11::path::_M_split_cmpts()'
> > heif_enc.cc:(.text+0x25ec): undefined reference to 
> > `std::filesystem::__cxx11::path::has_root_directory() const'
> > heif_enc.cc:(.text+0x2b64): undefined reference to 
> > `std::filesystem::__cxx11::path::has_filename() const'
> > 
> 
> Here a diff which should fix it. I haven't got access to sparc64 but it was
> compiled by gcc8 on -current/amd64
> 
> Index: multimedia/libheif/Makefile
> ===================================================================
> RCS file: /cvs/ports/multimedia/libheif/Makefile,v
> diff -u -p -r1.20 Makefile
> --- multimedia/libheif/Makefile       20 Mar 2025 08:58:49 -0000      1.20
> +++ multimedia/libheif/Makefile       29 Apr 2025 14:31:53 -0000
> @@ -1,6 +1,7 @@
>  COMMENT=     HEIF and AVIF file format decoder and encoder
>  
>  V=           1.19.7
> +REVISION=    0
>  DISTNAME=    libheif-$V
>  
>  SHARED_LIBS +=  heif 2.3
> Index: multimedia/libheif/patches/patch-libheif_CMakeLists_txt
> ===================================================================
> RCS file: multimedia/libheif/patches/patch-libheif_CMakeLists_txt
> diff -N multimedia/libheif/patches/patch-libheif_CMakeLists_txt
> --- /dev/null 1 Jan 1970 00:00:00 -0000
> +++ multimedia/libheif/patches/patch-libheif_CMakeLists_txt   29 Apr 2025 
> 14:31:53 -0000
> @@ -0,0 +1,14 @@
> +gcc8: undefined reference to 
> `std::filesystem::__cxx11::path::_M_split_cmpts()'
> +
> +Index: libheif/CMakeLists.txt
> +--- libheif/CMakeLists.txt.orig
> ++++ libheif/CMakeLists.txt
> +@@ -180,6 +180,8 @@ target_compile_definitions(heif
> +         LIBHEIF_EXPORTS
> +         HAVE_VISIBILITY)
> + 
> ++target_link_libraries(heif PUBLIC 
> $<$<AND:$<CXX_COMPILER_ID:GNU>,$<VERSION_LESS:$<CXX_COMPILER_VERSION>,9.0>>:stdc++fs>)
> ++
> + if (PLUGIN_LOADING_SUPPORTED_AND_ENABLED)
> +     target_compile_definitions(heif PRIVATE ENABLE_PLUGIN_LOADING=1)
> +     target_link_libraries(heif PRIVATE ${CMAKE_DL_LIBS})
> 
> 
> -- 
> wbr, Kirill
> 

Reply via email to