On Tue Apr 22, 2025 at 09:17:31AM +0100, Theo Buehler wrote: > On Tue, Apr 22, 2025 at 09:11:30AM +0200, Kirill A. Korinsky wrote: > > On Tue, 22 Apr 2025 07:51:38 +0200, > > Rafael Sadowski <raf...@sizeofvoid.org> wrote: > > > > > > On Mon Apr 21, 2025 at 10:55:01PM +0200, Kirill A. Korinsky wrote: > > > > ports@, > > > > > > > > I'd like to add two missed "inet" pledge for sysutils/tmate. > > > > > > > > The last one prevents it from start when I simple calls tmate, and the > > > > first one leads to crash when client is disconnect. > > > > > > > > Tested on -current/amd64. > > > > > > Confirmed, could we also ship this with 7.7-stable? > > > > > > > > > > > Ok? > > > > > > OK rsadowski@ > > > > > > > Thanks, commited. > > > > Also, it works on 7.6 and seems to be broken as side effect on 7.7 > > > > So, yes, I agree it worth to be backported. > > > > naddy@, sthen@, do you mind? > > To my knowledge, 7.7-stable is not yet open.
Yes, when it is open. > > Also, adding a pledge without giving a clear root cause is never the > right thing to do. At a minimum a ktrace should be provided. > > Why does this violate the inet pledge? Why does this work on 7.6? What > exactly changed in 7.7 so that it no longer works? > > These are questions that should be asked answered *before* commit. I assumed it was broken a long time ago but I can confirm that it works under 7.6 and we should analyze it
