On Mon, Apr 21, 2025 at 01:34:08PM +0200, Kirill A. Korinsky wrote:
> On Mon, 21 Apr 2025 00:51:11 +0200,
> Kirill A. Korinsky <kir...@openbsd.org> wrote:
> >
> > On Mon, 03 Mar 2025 21:30:58 +0100,
> > "Sergey A. Osokin" <o...@freebsd.org> wrote:
> > >
> > > Hi,
> > >
> > > could you please review and commit the following patch.
> > > Thank you.
> > >
> >
> > It reads well.
> >
> > Anyway, an attempt to run make test fails as:
> >
> > regexp optional tests: PASSED [13/13]
> > vm_json tests: PASSED [6/6]
> > vm_value tests: PASSED [8/8]
> > vm_internal_api tests: PASSED [31/31]
> > TOTAL: PASSED [5944/5944]
> > test/test262 --binary=build/njs
> > mktemp: insufficient number of Xs in template `/tmp/njs_test.XXX'
> > *** Error 1 in /build/pobj/njs-0.8.9/njs-0.8.9 (build/Makefile:994
> > 'test262_njs')
> > *** Error 2 in . (/usr/ports/infrastructure/mk/bsd.port.mk:3104
> > '/build/pobj/njs-0.8.9/.test_done': @cd /build/pobj/njs-0.8.9/njs-0.8.9 &&
> > e...)
> > *** Error 2 in /usr/ports/lang/njs
> > (/usr/ports/infrastructure/mk/bsd.port.mk:2712 'test': @lock=njs-0.8.9;
> > export _LOCKS_HELD=" njs-0.8.9";...)
> >
>
> This patch helps pass tests. Ok?
>
> Index: test/options
> --- test/options.orig
> +++ test/options
> @@ -3,7 +3,7 @@
> # Copyright (C) Dmitry Volyntsev
> # Copyright (C) NGINX, Inc.
>
> -NJS_TEST_DIR=`mktemp -d /tmp/njs_test.XXX`
> +NJS_TEST_DIR=`mktemp -d /tmp/njs_test.XXXXXX`
> NJS_TEST_LOG_DEFAULT="$NJS_TEST_DIR/log.log"
>
> NJS_TEST_VERBOSE=${NJS_TEST_VERBOSE:-}
LGTM, thanks, Kirill!
--
Sergey A. Osokin
