That would be 2 OKs from concerned citizens. So, could someone please
commit this or do we really need to wait for maintainer's response that
will most likely never arrive?
On Wed, 2025-04-16 at 21:41 +0200, Alvar Penning wrote:
> On Wed Apr 16, 2025 at 7:51 PM CEST, Igor Zornik wrote:
> > Thanks for the info. It seems their build process really does set
> > this
> > variable based on the git tag (that would be "r${R}" as opposed to
> > just
> > "${R}.
>
> Having the "r" included would mimic upstream, you are right. So feel
> free to include this as well.
>
> https://github.com/gokcehan/lf/blob/r34/gen/build.sh
>
> My main motivation was having the version in "lf -version" since
> currently it only tells the Go version being used for compilation.
>
> > No, I wouldn't mind setting this flag, but there is not much
> > point to this discussion without any feedback from the maintainer. I
> > wouldn't get my hopes up too much considering it's been over two
> > months
> > since the original submission (more so for R33).
>
> The last time I sent a diff for version 33, it was ignored. When I
> sent
> a diff updating from 28 to 32, the maintainer has not reacted as well.
> So I would assume the maintainer had lost interest.
>
> > Anyway, here's the amended diff. Rechecked with yesterday's amd64
> > snap.
>
> Thanks. I built it successfully. Works as intended.
>
> Best,
> Alvar
