Hi,

An update to the latest audio/squeezelite.

 - Since upstream has a weird workflow (no github releases or git tags), add a
   comment to let us know where to find the version number.

 - `rc_reload=NO` doesn't appear to be necessary.

 - Remove -z flag and use `rc_bg=YES` instead, so we can detect startup errors.
   (Spent too long figuring out what was going on when another user had sndiod
   locked and rc.subr was reporting squeezelite started ok when it hadn't --
   README does mention the sndio problem, but squeezelite isn't good at
   communicating the problem)

 - There are some compilation warnings (and they were there before too) which
   I've (lazily) reported upstream here: 
   https://github.com/ralph-irving/squeezelite/issues/242

Tested with my local setup -- seems to work fine.

OK?

P.S. I'm willing to bet that the audio/squeezecenter port is in dire need of
update. I haven't tried it, but the project -- at least under that name -- died
a long time ago, but there's a fork called "lyrion" which is probably what we
should be using: https://lyrion.org/ . Maybe I'll have a look one day.


Index: Makefile
===================================================================
RCS file: /cvs/ports/audio/squeezelite/Makefile,v
diff -u -p -r1.21 Makefile
--- Makefile    8 Oct 2024 03:43:48 -0000       1.21
+++ Makefile    15 Mar 2025 12:46:03 -0000
@@ -1,9 +1,12 @@
 COMMENT=       lightweight headless squeezebox player
 
-V=             1.9.9.1430
+# Find this in squeezelite.h.
+# It's the developer's internal subversion ID before he pushes it to github:
+# https://github.com/ralph-irving/squeezelite/issues/29#issuecomment-319686292
+V=             2.0.0.1524
 GH_ACCOUNT=    ralph-irving
 GH_PROJECT=    squeezelite
-GH_COMMIT=     663db8f64d73dceca6a2a18cdb705ad846daa272
+GH_COMMIT=     db51a7b16934f41b72437394bf8114c3a85e0a91
 DISTNAME=      squeezelite-$V
 
 CATEGORIES=    audio
Index: distinfo
===================================================================
RCS file: /cvs/ports/audio/squeezelite/distinfo,v
diff -u -p -r1.6 distinfo
--- distinfo    14 May 2023 12:10:42 -0000      1.6
+++ distinfo    15 Mar 2025 12:46:11 -0000
@@ -1,2 +1,2 @@
-SHA256 (squeezelite-1.9.9.1430-663db8f6.tar.gz) = 
0rz8xdHq3uNWYhZcXMRibEAmNpukrpz9p3hkvR0B72s=
-SIZE (squeezelite-1.9.9.1430-663db8f6.tar.gz) = 167218
+SHA256 (squeezelite-2.0.0.1524-db51a7b1.tar.gz) = 
aaW/codL8Q3aDNMBovCNqra0hELqhLXjcpURkVpuHuc=
+SIZE (squeezelite-2.0.0.1524-db51a7b1.tar.gz) = 173466
Index: pkg/squeezelite.rc
===================================================================
RCS file: /cvs/ports/audio/squeezelite/pkg/squeezelite.rc,v
diff -u -p -r1.3 squeezelite.rc
--- pkg/squeezelite.rc  11 Mar 2022 18:20:32 -0000      1.3
+++ pkg/squeezelite.rc  15 Mar 2025 12:40:20 -0000
@@ -1,10 +1,13 @@
 #!/bin/ksh
 
-daemon="${TRUEPREFIX}/bin/squeezelite -z"
+daemon="${TRUEPREFIX}/bin/squeezelite"
 daemon_user="_squeezelite"
 
 . /etc/rc.d/rc.subr
 
-rc_reload=NO
+# Although squeezelite does support deamonisation with -z, we let rc.subr do
+# the daemonisation so that we can catch startup errors at rc_start time (e.g.
+# when there is no access to sndiod, it just exits non-zero).
+rc_bg=YES
 
 rc_cmd $1

-- 
Best Regards
Edd Barrett

https://www.theunixzoo.co.uk

Reply via email to