Stuart Henderson <s...@spacehopper.org> writes:
> On 2025/03/09 16:16, Sebastien Marie wrote:
>> Hi,
>>
>> The following diff updates textproc/slipshow to 0.1.0
>>
>> 0.1.0 has a tarball, so use it instead of using generated github
>> tarball.
>>
>> it also has a dependency on forked brr. So fetch it and put it in
>> WRKSRC.
>>
>> Comments or OK ?
>
> Please would you remove GH_*, that is just meant for the git-archive
> downloads and is a bit confusing when combined with SITES.
>
> Suggested diff on top of yours, this also uses DIST_TUPLE to simplify
> fetching the forked brr.
thanks. I commited the update with your suggested changes.
> --- Makefile- Sun Mar 9 16:04:41 2025
> +++ Makefile Sun Mar 9 16:07:42 2025
> @@ -7,10 +7,10 @@ NOT_FOR_ARCHS = i386
>
> COMMENT = compiler from markdown to slipshow
>
> -GH_ACCOUNT = panglesd
> -GH_PROJECT = slipshow
> -GH_TAGNAME = v${V}
> V = 0.1.0
> +DISTNAME = slipshow-${V}
> +EXTRACT_SUFX = .tbz
> +HOMEPAGE = https://github.com/panglesd/slipshow
>
> CATEGORIES = textproc
>
> @@ -29,12 +29,10 @@ MODOPAM_REPO_NAME = slipshow-opam-20250307
> MODOPAM_PACKAGES = slipshow.${V}
>
> SITES =
> https://github.com/panglesd/slipshow/releases/download/v${V}/
> -DISTFILES = slipshow-${V}.tbz
>
> # https://github.com/panglesd/brr.git#bindings-window-inner-size
> -SITES.brr = https://github.com/panglesd/brr/archive/
> -DISTFILES.brr = panglesd-brr-{}${COMMIT.brr}.tar.gz
> COMMIT.brr = 1de3a5c774360b97f413090c181afebc94bff569
> +DIST_TUPLE = github panglesd brr ${COMMIT.brr} brr
>
> SITES.opamrepo = https://kapouay.eu.org/pub/opam/
> DISTFILES.opamrepo = ${MODOPAM_REPO_NAME}.tar.gz
> @@ -46,9 +44,6 @@ LIB_DEPENDS += devel/libev
> CONFIGURE_STYLE += opam
>
> SEPARATE_BUILD = Yes
> -
> -post-extract:
> - mv ${WRKDIR}/brr-${COMMIT.brr} ${WRKSRC}/brr
>
> post-install:
> rm -rf -- ${PREFIX}/lib/ocaml/slipshow
>
--
Sebastien Marie
