FWIW, the 'cosmetic' bits were suggested at the time when the port was first
submitted:

https://marc.info/?l=openbsd-ports&m=170636754625105&w=2

I think we should keep the bits removing the ANSI colour sequences.

On 2025-02-17 11:41, izzy Meyer wrote:
On Sun, 16 Feb 2025 23:49:00 +0000
David Uhden Collado <da...@uhden.dev> wrote:

In this email, I have attached a diff to update sysutils/btop from
version 1.3.2 to version 1.4.0 [1].

I fixed a problem that prevented the manual page for this program
from being generated due to the lack of textproc/lowdown at build
time, and I updated and simplified the patch for the Makefile,
leaving only the necessary parts and removing the aesthetic changes.

Tested on amd64 and it builds and runs fine.

OKs? Comments?

References:
[1]: https://github.com/aristocratos/btop/releases/tag/v1.4.0

Tested it on amd64 and arm64. Runs OK, the manpage is generated,
and installs correctly for me as well. Although, It'd probably be better
if the manpage is installed to ${PREFIX}/man/ rather than
${PREFIX}/share/man/.

according to portcheck:
manual pages should go under ${PREFIX}/man/ rather than under
${PREFIX}/share/man/

Here's an updated diff that fixes the manpage install location:

With this diff, OK from me.

Thanks-

--
iz (she/her)

i like to say mundane things,
there are too many uninteresting things
that go unnoticed.

izder456 (dot) neocities (dot) org


Reply via email to