rsadowski@ noticed that portbump started showing a warning about calling
an undefined "import" method:


    Attempt to call undefined import method with arguments ("w_stem")
    via package "Util" (Perhaps you forgot to load the package?) at
    ./infrastructure/bin/portbump line 68.


This is because, due to improvements in the way "import" works, which
means no longer hiding this warning as a special case.

https://perldoc.perl.org/perl5400delta#Calling-the-import-method-of-an-unknown-package-produces-a-warning

This did indicate that Utils never actually _had_ an `import` method and
that import never actually worked, as seems to be indicated by all calls
to "w_stem" in the main are fully qualified as "Utils::w_stem".

I silenced the warning by importing import, but it seems just as useful
to remove the @EXPORT and the call to Utils->import in PortHandler.

Comments, OK?


Index: infrastructure/bin/portbump
===================================================================
RCS file: /cvs/ports/infrastructure/bin/portbump,v
retrieving revision 1.24
diff -u -p -r1.24 portbump
--- infrastructure/bin/portbump 21 Dec 2024 11:40:34 -0000      1.24
+++ infrastructure/bin/portbump 7 Feb 2025 22:57:29 -0000
@@ -21,7 +21,7 @@ use strict;
 use warnings;
 
 BEGIN {
-       require Exporter;
+       use Exporter qw(import);
        our @EXPORT = qw(plibs phash w_stem);
 }
 

Reply via email to