On Thu, 30 Jan 2025 00:01:55 +0100, Theo Buehler wrote: > > New version 0.20.4. > > > > This sets USE_NOBTCFI and USE_NOEXECONLY just like ncspot, though it > > would be VERY much preferable if aws-lc either just solved the issues or > > librespot switched back to ring > > (https://github.com/librespot-org/librespot/issues/1382). > > Yes. > > I don't have a spotify account, so this was only build tested. > > Would you mind moving USE_NOBTCFI and USE_NOEXECONLY to the top with a > comment matching what sthen added in librespot? It helps those of us who > keep an eye on them. > > Also a comment above the BDEP on lang/llvm/18 like ncspot would be helpful > > With those tweaks,
Done. > ok tb > > I think sthen is right that a variable for this in cargo.port.mk would > make sense to obviate the need to keep these in sync. On rust updates, > all rust ports are rebulit anyway, so if rust switches to llvm 19 that > would be picked up automatically. Yes. > Finally, out of curiosity: what's the story behind the -Werror patch? clang not finding a declaration for arc4random_buf(3) in aws-lc despite (apparently) correctly guarded includes and me not having the nerve to take a deep dive into a cmake-invoked-by-cargo build system to hunt the bug (which is fixed in their git HEAD). On another note, this is the type of port that should be pretty straightforward to pledge(2) and unveil(2).
spotify-player.tgz
Description: spotify-player.tgz
