> I tired to add support for *.sub (MicroDVD) subtitles type and it seems
> to work.
> Any thought are welcome.
> Index: metadata.c
> --- metadata.c.org
> +++ metadata.c
> @@ -146,6 +146,11 @@
> strcpy(p, ".smi");
> ret = access(file, R_OK);
> }
> + if (ret != 0)
> + {
> + strcpy(p, ".sub");
> + ret = access(file, R_OK);
> + }
>
Even if the rest of the code is littered with strcpy(), it feels like
patches should not add more bad calls to it.
I have no other comments the port, on adding titles or whatever, it
just feels wrong to add more calls to a function that the linker
already warns about in code which is meant to improve a port for
openbsd use.
--
May the most significant bit of your life be positive.
