On 2025/01/16 16:06, Matthias Pitzl wrote:
> +WANTLIB-modsecurity3=        ${COMPILER_LIBCXX} c curl crypto iconv lzma m \
> +                     maxminddb modsecurity nghttp2 nghttp3 ngtcp2 \
> +                     ngtcp2_crypto_quictls pcre pcre2-8 pthread ssl xml2 yajl
...
> +LIB_DEPENDS-modsecurity3=    converters/libiconv \
> +                             devel/libyajl \
> +                             devel/pcre \
> +                             devel/pcre2 \
> +                             net/libmaxminddb \
> +                             net/ngtcp2 \
> +                             security/libmodsecurity \
> +                             textproc/libxml \
> +                             www/nghttp2 \
> +                             www/nghttp3

too many WANTLIB and LIB_DEPENDS, most of those are not used by either
libmodsecurity or this plugin but instead are just used by curl.

"make port-lib-depends-check" is happy with just

WANTLIB-modsecurity3=           modsecurity
LIB_DEPENDS-modsecurity3=       security/libmodsecurity

> +++ pkg/DESCR-modsecurity3    13 Jan 2025 12:46:53 -0000
> @@ -0,0 +1,3 @@
> +The ModSecurity-nginx module provides a connector for libmodsecurity to 
> nginx.
> +
> +WWW: https://github.com/SpiderLabs/ModSecurity-nginx

the URL comes from the HOMEPAGE setting, don't add it to DESCR

> @@ -0,0 +1 @@
> +ngx_http_modsecurity_module.so

there should be an @so tag, did you generate this by hand and just
miss it, or did "make update-plist" leave it out?

... also:

please make sure that the recent libmodsecurity update builds ok on
sparc64 (the update moved it from c++11 to c++17) - if you can't build
yourself then wait for next bulk build results - if libmodsecurity
fails then adding this will knock out nginx on sparc64.

Reply via email to