On 2025/01/15 21:49, Johannes Thyssen Tishman wrote:
> 2025-01-15T19:10:23Z Ian Darwin <i...@darwinsys.com>:
> 
> > On 1/7/25 12:46 PM, Johannes Thyssen Tishman wrote:
> > > Please find attached a port for cad/netgen-mesher and one of its test
> > > dependencies devel/py-test-check. This port is required by
> > > cad/freecad,
> > > a port I intend to submit once it's dependencies have been comitted.

$ head -1 pkg/PLIST
@conflict netgen-*

This is likely to be a problem. As it provides a library I guess freecad
will need it at build time, not just install time. We can't have two
ports which are in-conflict as BUILD or LIB_DEPENDS of other ports (the
existing netgen is a BDEP of qflow) because it will cause bulk builds
to fail sometimes.

Currently only the file /usr/local/bin/netgen conflicts. It would be
preferable to rename in one or other port to avoid the conflict.
cad/netgen got there first, so I think it would be preferable to
rename this one.

> > > $ portcheck
> > > Python module without compiled version, consider using
> > > ${MODPY_COMPILEALL}: share/netgen/py_tutorials/exportNeutral.py
> > > 
> > > Python module without compiled version, consider using
> > > ${MODPY_COMPILEALL}: share/netgen/py_tutorials/mesh.py
> > > cad/netgen-mesher
> > 
> > Dunno if these matter, since it builds. Otherwise ok ian@
> 
> I ignored these as they are tutorials/examples. I'm indifferent about their
> installation, so we can also leave them out if it's preferred. Thanks Ian.

portcheck is annoying. It whines about this non-problem (only modules
that get imported by other Python code should be bytecode-compiled -
despite missing #! these are just standalone example scripts), but
not about hardcoding python3.12/tcl86/tk86 in WANTLIB.

Here's an updated set of WANTLIB lines.

WANTLIB += ${COMPILER_LIBCXX} ${MODPY_WANTLIB} ${MODTK_WANTLIB}
WANTLIB += GL GLU TKBO TKBRep TKBool TKCAF TKCDF TKDE TKDEIGES
WANTLIB += TKDESTEP TKDESTL TKFillet TKG2d TKG3d TKGeomAlgo TKGeomBase
WANTLIB += TKHLR TKLCAF TKMath TKMesh TKOffset TKPrim TKService
WANTLIB += TKShHealing TKTopAlgo TKV3d TKVCAF TKXCAF TKXSBase
WANTLIB += TKernel X11 Xmu c execinfo fontconfig freetype jpeg
WANTLIB += m z

Other small things, the doc should be renamed to the ports-standard
location:

share/netgen/doc/ng4.pdf -> share/doc/netgen-mesher/ng4.pdf

and also perhaps share/netgen/py_tutorials -> share/examples/netgen-mesher?

Reply via email to