Am Sat, Dec 28, 2024 at 01:16:42PM +0000 schrieb Stuart Henderson: > On 2024/12/28 00:06, Kirill A. Korinsky wrote: > > Martint, ports@, > > > > I'd like to add ical2rem.pl to misc/remind port. > > > > My usecase of this small script is automatical import .ical to remind which > > I use to generate daily emails with a schedule of the day. > > > > Feedback? Ok? > > > > Index: misc/remind/Makefile > > =================================================================== > > RCS file: /home/cvs/ports/misc/remind/Makefile,v > > diff -u -p -u -p -r1.80 Makefile > > --- misc/remind/Makefile 20 Dec 2024 14:00:53 -0000 1.80 > > +++ misc/remind/Makefile 27 Dec 2024 22:50:16 -0000 > > @@ -2,6 +2,8 @@ COMMENT= scripting language for reminder > > > > DISTNAME= remind-05.02.01 > > PKGNAME= remind-5.2.1 > > +I2R_V= 0.8 > > +REVISION= 0 > > Adding it to remind like this is a bit awkward, why not add a separate > port? I don't know, if a single script should really be a individual port.
But installing this patch, I found the dependencies where not used (on my system) So I guess, there are reasons not to include other scripts. Thinking about it: I use another local port to update from remind to baikal, if this gets included too and so on it would get complicated! In short: Stuart Henderson seems to be right, even if my first idea was also to include this single script to the existing port. Anyways i tested it and it works here. > > > CATEGORIES= misc > > > > @@ -9,7 +11,8 @@ HOMEPAGE= https://dianne.skoll.ca/projec > > > > MAINTAINER= Martin Ziemer <hor...@horrad.de> > > > > -# GPLv2 only > > +# remind: GPLv2 only > > +# ical2rem.pl: MIT > > PERMIT_PACKAGE= Yes > > > > COMPILER= base-clang ports-gcc > > @@ -19,6 +22,11 @@ WANTLIB= c m > > > > SITES= > > https://dianne.skoll.ca/projects/remind/download/ > > > > +SITES.i2r= https://github.com/jbalcorn/ical2rem/raw/refs/tags/ > > +DISTFILES.i2r = ical2rem-${I2R_V}{v${I2R_V}/ical2rem}.pl > > I don't like relying on github's URL formats in individual ports, I'd > prefer to use DIST_TUPLE > > > + > > +EXTRACT_ONLY = ${DISTFILES} > > + > > TEST_ENV= LC_ALL=en_US.UTF-8 > > > > MODULES= x11/tk > > @@ -34,6 +42,10 @@ RUN_DEPENDS= ${MODTK_RUN_DEPENDS} \ > > devel/p5-Pango \ > > devel/desktop-file-utils > > > > +# ical2rem deps > > +RUN_DEPENDS+= devel/p5-Time-TimeDate \ > > + productivity/p5-iCal-Parser > > + > > CONFIGURE_STYLE= gnu > > > > TEST_TARGET= test > > @@ -44,5 +56,7 @@ pre-configure: > > post-install: > > ${INSTALL_DATA_DIR} ${PREFIX}/share/examples/remind > > ${INSTALL_DATA} ${WRKSRC}/examples/* ${PREFIX}/share/examples/remind > > + ${INSTALL_SCRIPT} ${FULLDISTDIR}/ical2rem-${I2R_V}.pl \ > > + ${PREFIX}/bin/ical2rem > > > > .include <bsd.port.mk> > > Index: misc/remind/distinfo > > =================================================================== > > RCS file: /home/cvs/ports/misc/remind/distinfo,v > > diff -u -p -u -p -r1.49 distinfo > > --- misc/remind/distinfo 20 Dec 2024 14:00:53 -0000 1.49 > > +++ misc/remind/distinfo 27 Dec 2024 22:39:58 -0000 > > @@ -1,2 +1,4 @@ > > +SHA256 (ical2rem-0.8.pl) = WNUNBt+Bc3Mu4WfbKjQRIbR0kXnUixrVBwFNKtDTCWE= > > SHA256 (remind-05.02.01.tar.gz) = > > CVtfChpwFtyITaW7ZJ/zbxMyM4pWsjsgwaqnSWYiL18= > > +SIZE (ical2rem-0.8.pl) = 15067 > > SIZE (remind-05.02.01.tar.gz) = 4519636 > > Index: misc/remind/pkg/PLIST > > =================================================================== > > RCS file: /home/cvs/ports/misc/remind/pkg/PLIST,v > > diff -u -p -u -p -r1.21 PLIST > > --- misc/remind/pkg/PLIST 20 Dec 2024 14:00:53 -0000 1.21 > > +++ misc/remind/pkg/PLIST 27 Dec 2024 22:43:25 -0000 > > @@ -1,3 +1,4 @@ > > +bin/ical2rem > > bin/rem > > bin/rem2html > > bin/rem2pdf > > > > > > -- > > wbr, Kirill
