On 2024/12/28 09:51, Chaz Kettleson wrote: > I've been running this for a while and continued to do testing without > issues. Can we get this committed? Or is someone willing to take a look.
I'm not a fan of building up the promises string dynamically. The approach I've normally seen used would be to pledge with the maximal promises set first, then call pledge again with a smaller set to revoke the unneeded ones as they're determined. That uses static strings so doesn't require that they're in writable memory. I don't run an IRC server and it's not clear how to test without that. I see the port's rc script permits reload (no rc_reload=NO) - how does this hold up to reloading with different config (i.e. changing from config which doesn't need file access, to config which does)?
