On 2024/12/23 16:56, Landry Breuil wrote:
> Le Mon, Dec 23, 2024 at 02:26:08PM +0000, Stuart Henderson a écrit :
> > If another ports dev has time, could you take a look at these please?
> > They're ok with me, so either I need another ok or for someone to
> > commit. They're part of the set of ports that Johannes has written for
> > freecad, it would be nice to get them in.
I missed that ian@ already imported med, oops!
> id be generally ok with those, one nit, i've seen an inconsistency
> between them where one has WITH_MPI=OFF and the other has WITH_MPI=ON.
looks ok in these versions;
$ ag MPI math/flann graphics/pcl math/med
math/flann/Makefile
15:WANTLIB += ${COMPILER_LIBCXX} lz4 m
17:COMPILER = base-clang ports-gcc
32: -DUSE_MPI=OFF
graphics/pcl/Makefile
34:WANTLIB += ${COMPILER_LIBCXX} boost_filesystem-mt boost_iostreams-mt
38:COMPILER = base-clang ports-gcc
math/med/Makefile
22:WANTLIB += ${COMPILER_LIBCXX} c hdf5 m z
24:COMPILER = base-clang ports-gcc
36: -DMEDFILE_USE_MPI=OFF \
might have been different in an older one possibly.
> also, i'll have to triplecheck but geo/pdal might pick pcl if it's find
> at configure time, cf
> https://github.com/PDAL/PDAL/blob/master/plugins/teaser/CMakeLists.txt#L35
> (but other requirements might be missing for that given plugin, so that
> might just be a non-issue)
>
> ok anyway to move forward :)
looks ok, that requires the TEASER++ library, and the whole plugin is
for supporting that anyway, so we can probably just add that if that
gets imported sometime. (also requires openmp).
Will import pcl/flann.
