Le Wed, Dec 04, 2024 at 03:47:40PM -0500, Thomas Frohwein a écrit : > Hi, > > Please find attached 2 diffs, for graphics/volk and > graphics/vulkan-tools to move volk's files into vulkan_volk/ subdir. > After some experimentation with other solutions, this seems to be the > best and easiest to maintain going forward. > > Background is that gnuradio has a dependency on another library also > called volk, so this is to de-conflict this. > > Currently vulkan-tools is the only reverse dependency of graphics/volk, > so the diff for it addresses any fallout. > > ok? comments?
i like this; i wanted to make sure that libvolk.a was actually used, so i @comment'ed it in volk's PLIST, and vulkan-tools failed to build, so it *is* used. looking at volk build log, libvolk.a actually only contains the volk.c file, so another option would have been to modify more heavily the cmakery in vulkan-tools (as you already tried and we discussed about it privately), but that feels too gross. since only vulkan-tools uses it, i think it makes sense to do it this way, and i've checked that vulkan-tools correctly builds with that moved libvolk.a. all that to say ok :) and thanks for untangling it ! Landry
