On 2024-12-04 1:38 p.m., Kirill A. Korinsky wrote:
On Wed, 04 Dec 2024 10:49:23 +0100,
Stuart Henderson <s...@spacehopper.org> wrote:
Something, probably the x265 update, broke HandBrake?
/pobj/handbrake-1.6.1/HandBrake-1.6.1/libhb/encx265.c:444:20: warning: comparison
of array 'param->csvfn' equal to a n
ull pointer is always false [-Wtautological-pointer-compare]
if (param->csvfn == NULL)
~~~~~~~^~~~~ ~~~~
/pobj/handbrake-1.6.1/HandBrake-1.6.1/libhb/encx265.c:447:26: error: array type
'char[256]' is not assignable
param->csvfn = strdup(pv->csvfn);
~~~~~~~~~~~~ ^
1 warning and 1 error generated.
My attempt to update it to 1.9.0 leads to an issues that x265 needs this
patches: https://github.com/HandBrake/HandBrake/tree/1.9.0/contrib/x265
After that, it needs this patches for our ffmpeg:
https://github.com/HandBrake/HandBrake/tree/1.9.0/contrib/ffmpeg
and so on, and so on.
At some point I had discovered that upstream made it clear that without
patching ffmpeg HandBrake is broken, see:
https://github.com/HandBrake/HandBrake/issues/6179
Can we updated HandBrake? Probably.
I was not aware of the issue with sub-titles.
If I did switch the build infrastructure to using it's own depends a bit
more
I'd see if it can build just FFmpeg and x265 as that's the only contrib bits
they patch. But then our patches have to be added back in the contrib
framework.
