On Wed, Dec 04, 2024 at 11:04:54PM +0100, Theo Buehler wrote: > > Everything works fine in my testing. A symbol was removed so I bumped > > the minor for SHARED_LIBS. > > If a symbol was removed then you need to do a major bump. I see no > symbol removal. > > However, the public struct lowdown_opts has a new member. This changes > the ABI and therefore requires a major bump (I found that by diffing the > old and the new lowdown.h). > > This is a short summary on bumps: > > https://www.openbsd.org/faq/ports/specialtopics.html#SharedLibs > > The long doc comment in /usr/src/lib/check_sym gives a more technial > intro to this. The script is useful for a basic check: > > $ /usr/src/lib/check_sym /usr/local/lib/liblowdown.so.1.1 \ > /usr/ports/pobj/lowdown-1.3.0/fake-amd64/usr/local/lib/liblowdown.so.2.0 > /usr/local/lib/liblowdown.so.1.1 --> > /usr/ports/pobj/lowdown-1.3.0/fake-amd64/usr/local/lib/liblowdown.so.2.0 > No dynamic export changes > External reference changes: > added: > _toupper_tab_ > > The no dynamic export changes mean that no symbol was removed. > But as you can see, it's not able to catch everything.
Thank you for the detailed explanations. I misread my notes and ran check_sym against the new and then old which showed a removed _toupper_tab_ which was obviously wrong and should have shown added instead if I had run it correctly. > In addition, for an update you should always run 'make update-plist' > and 'make update-patches' to be sure patches (if any) and packing list > are updated. Thank you. I did that now. Here is the correct diff that is the same as what you had below also. Bryan Index: textproc/lowdown/Makefile =================================================================== RCS file: /cvs/ports/textproc/lowdown/Makefile,v diff -u -p -u -r1.34 Makefile --- textproc/lowdown/Makefile 24 Nov 2024 12:41:25 -0000 1.34 +++ textproc/lowdown/Makefile 5 Dec 2024 02:01:43 -0000 @@ -1,8 +1,8 @@ COMMENT = simple markdown translator -DISTNAME = lowdown-1.2.0 +DISTNAME = lowdown-1.3.0 CATEGORIES = textproc -SHARED_LIBS = lowdown 1.1 # 2 +SHARED_LIBS = lowdown 2.0 # 2 HOMEPAGE = https://kristaps.bsd.lv/lowdown/ MAINTAINER = Bryan Vyhmeister <br...@bsdjournal.net> Index: textproc/lowdown/distinfo =================================================================== RCS file: /cvs/ports/textproc/lowdown/distinfo,v diff -u -p -u -r1.29 distinfo --- textproc/lowdown/distinfo 24 Nov 2024 12:41:25 -0000 1.29 +++ textproc/lowdown/distinfo 4 Dec 2024 20:59:36 -0000 @@ -1,2 +1,2 @@ -SHA256 (lowdown-1.2.0.tar.gz) = SoU+Hkm8pu9TLQdSKLhFhaKdiLv0p9JqcMXU3yYLmj8= -SIZE (lowdown-1.2.0.tar.gz) = 280790 +SHA256 (lowdown-1.3.0.tar.gz) = 6eFXsaAybyNSiA4vQg8RWdInocVwFa4R/29YLF3lhBg= +SIZE (lowdown-1.3.0.tar.gz) = 291024 Index: textproc/lowdown/pkg/PLIST =================================================================== RCS file: /cvs/ports/textproc/lowdown/pkg/PLIST,v diff -u -p -u -r1.15 PLIST --- textproc/lowdown/pkg/PLIST 27 Jul 2022 08:59:09 -0000 1.15 +++ textproc/lowdown/pkg/PLIST 5 Dec 2024 02:05:22 -0000 @@ -40,5 +40,7 @@ lib/pkgconfig/lowdown.pc @man man/man3/lowdown_tree_rndr.3 @man man/man5/lowdown.5 share/lowdown/ +share/lowdown/html/ +share/lowdown/html/default.html share/lowdown/odt/ share/lowdown/odt/styles.xml
