On 2024/11/29 07:31, wen heping wrote:
> Here is the revised patch based on the suggestions of Rafael Sadowski
> to create astro/stellarsolver.
still not ok, see my previous mail
> ________________________________________
> 发件人: Rafael Sadowski <raf...@sizeofvoid.org>
> 发送时间: 2024年11月23日 15:47
> 收件人: wen heping
> 抄送: ports@openbsd.org
> 主题: Re: [NEW]astro/stellarsolver
>
> On Wed Nov 13, 2024 at 11:21:57AM +0000, wen heping wrote:
> > Hi, ports@:
> >
> > Here is a patch to create new port astro/stellarsolver,
> > which is required by the update of astro/kstars.
> > It build well on my amd64-current system.
> >
> > Cheers !
> > wen
>
> Thanks for the work. I'm OK with the diff with one tweak and one correction.
> First, we should move MODULES above LIB_DEPENDS (It's clearer for me
> to know which MODULES are invoke before I read the LIB_DEPENDS -- I
> always read from top to button). Next, if we use the qt5, you gain qtbase
> in LIB_DEPENDS for free. Last but most imported your WANTLIB was not correct.
>
> With this OK to import stellarsolver. If this is imported I'll take a
> look on kstars.
>
> Rafael
>
> --- /tmp/astro/stellarsolver/Makefile Tue Nov 12 08:05:47 2024
> +++ Makefile Sat Nov 23 08:38:42 2024
> @@ -12,21 +12,21 @@ MAINTAINER= Wen Heping <wenheping2...@hotmail.com>
>
> SHARED_LIBS= stellarsolver 0.0 # 0.0
>
> -WANTLIB += c cfitsio gsl wcs
> +WANTLIB += ${COMPILER_LIBCXX} Qt5Concurrent Qt5Core Qt5Gui Qt5Network
> +WANTLIB += Qt5Widgets cfitsio gsl gslcblas m wcs
>
> # GPLv3
> PERMIT_PACKAGE= Yes
>
> SITES= https://github.com/rlancaste/stellarsolver/archive/refs/tags/
>
> +MODULES= devel/cmake \
> + x11/qt5
> +
> LIB_DEPENDS= astro/wcslib \
> devel/gsl \
> - math/cfitsio \
> - x11/qt5/qtbase,-main
> + math/cfitsio
>
> WRKDIST= ${WRKDIR}/stellarsolver-${V}
> -
> -MODULES= devel/cmake \
> - x11/qt5
>
> .include <bsd.port.mk>
