On 2024/11/27 21:48, George Koehler wrote: > On Wed, 16 Oct 2024 18:46:14 -0500 > izzy Meyer <izder...@disroot.org> wrote: > > > Hello ports@ > > > > This port has stayed dormant in the mailing list for quite some time. > > > > Any committers willing to look at this? > > > > Attached again for ease of looking over. > > Import is ok gkoehler@ > > Maybe drop the pkg/README? The README only repeats some info from > "man nxbelld", and I still needed to read "man nxbelld" to learn the > command-line options.
definitely, that is all information which is copied from the manual. > I attach the port yet again; it's the same .tgz that izzy mailed in > October. I never had a beeper, so I now need nxbelld to hear beeps. > > The sndio in nxbelld adds a little noise; > $ nxbelld -bf quack.wav > $ echo '\a' > didn't sound good, so I switched to > $ nxbelld -be 'aucat -i quack.wav' That combined with the manpage text "When using sndio, the beeps are slightly shorter than the specified beep duration. Beeps of 120 ms or shorter don't get played at all" suggests that the sndio code is not quite correct. diff below with other tweaks (plus rm pkg/README), the PKGNAME/HOMEPAGE bits are all set by DIST_TUPLE and there's no need for a separate V If it's a C program then setting COMPILER to "base-clang ports-gcc base-gcc" can never be right (if it builds with base-gcc and doesn't use C++ libraries then there's no need to specify this). As was set here it means that on ports-gcc archs there would be add a LIB_DEPENDS on ports-gcc's C++ libraries. This is what Makefile.template has to say: # Standard for C++ ports: #COMPILER = base-clang ports-gcc base-gcc # Standard for C++11 or newer: #COMPILER = base-clang ports-gcc # Ports that require a non-default compiler that do *not* use C++ should set this: #COMPILER_LANGS = c diff --git a/x11/nxbelld/Makefile b/x11/nxbelld/Makefile index 49ecff1..47bfc56 100644 --- a/x11/nxbelld/Makefile +++ b/x11/nxbelld/Makefile @@ -1,14 +1,9 @@ COMMENT = fork of xbelld, the X bell daemon for machines w/o a pcspkr -V = 0.1.2 -PKGNAME = nxbelld-$V - -DIST_TUPLE += github dusxmt nxbelld $V . +DIST_TUPLE += github dusxmt nxbelld 0.1.2 . CATEGORIES = x11 -HOMEPAGE = https://github.com/dusxmt/nxbelld - MAINTAINER = izzy Meyer <izder...@disroot.org> # GPL v3+ @@ -16,8 +11,6 @@ PERMIT_PACKAGE = Yes WANTLIB += X11 c m sndio -COMPILER = base-clang ports-gcc base-gcc - USE_GMAKE = Yes CONFIGURE_STYLE = autoreconf diff --git a/x11/nxbelld/pkg/PLIST b/x11/nxbelld/pkg/PLIST index 2681ce0..6afaa64 100644 --- a/x11/nxbelld/pkg/PLIST +++ b/x11/nxbelld/pkg/PLIST @@ -1,3 +1,2 @@ @bin bin/nxbelld @man man/man1/nxbelld.1 -share/doc/pkg-readmes/${PKGSTEM}
