Mike Erdely wrote:
> On Sun, Sep 09, 2007 at 12:57:30PM -0700, Roland Philippsen wrote:
>> here's a suggestion for adding an Apache2-flavor to www/mod_fastcgi.
>> The patch (created with git) is best applied using 'patch -p2' from
>> within the mod_fastcgi directory. The unflavored build is identical to
>> what's in CVS right now, specifying FLAVOR=ap2 builds it for
>> www/apache-httpd.

...

> I tested this on macppc and i386.  Works as expected.
> 
> I made a couple tweaks and used "cvs diff" (below).
>  - I removed your "flavored_" PKGNAME prefix.
>  - I added "@comment share/.../mod_fastcgi.html.orig" to PFRAG.ap2 so
>    update-plist doesn't change any files.
> 
> Any comments for the below diff?

Thanks! Works swell here (amd64).

One (general) question: what are the recommendations regarding the use
of quotes in COMMENT? I've seen patches that remove those, and some
ports obviously still have them...

Greetings,
Roland

Reply via email to