On Tue, 26 Nov 2024 07:12:51 +0100,
Sebastien Marie <sema...@kapouay.eu.org> wrote:
>
> Kirill A. Korinsky <kir...@korins.ky> writes:
>
> > Additionally, I'd like to add MODCARGO_CARGOLOCK variable into
> > devel/cargo/cargo.port.mk which allows to run make modcargo-gen-crates on
> > this port without commenting WRKSRC.
>
> I saw it because of the commit.
>
> I don't understand the problem for now. The lockfile is generated from
> the toml file by cargo, and it seems to me that it can't be at a
> different place than the toml file.
>
The root case that mitmproxy_rs contains a few "projects" in one archive and
needed one in mitmproxy_rs subfolder. And build by maturin should be run in
required subfolder, not the root folder. That's why the Makefile contains:
WRKSRC = ${WRKDIST}/mitmproxy-rs
Anyway, Cargo.lock exists at the root folder of archive.
> Introducing a user variable for a development target is at least
> questionnable ('make modcargo-gen-crates MOCARGO_TOML=...' could do the
> trick).
>
Yes, make modcargo-gen-crates 'MODCARGO_CARGOTOML=${WRKDIST}/Cargo.toml' do
the trick, but it a kind of hack which is needed each time to when I update
this port.
If you uncomfortable with my hack that introduced MODCARGO_CARGOLOCK, I
appologize that commited it and forgot add you to Cc at the first place, and
absolutley fine if you revert it.
--
wbr, Kirill
