On 2024/11/21 06:11, Jeremy Evans wrote:
> The quirk for old ruby versions was removed at some point in the last
> year. I think it was in the commit that removed quirks for old OpenBSD
> versions, since it was listed in a section for old OpenBSD versions,
> and just updated every time we removed support for a ruby version.

Yes I was not expecting to see anything current in the section for 6.8
;)

> Here's a diff to add it back to a separate section at the top, and
> updates it to include ruby31-*. Do we want this?
...
>  setup_obsolete_reason(
> +# Ruby
> +     3 => qr{^(ruby(19|2[0-7]|3[01])-|^j?ruby-[^0-9])},
>  # 6.9
>       3 => 'py-notify',
>       3 => 'glimpse',

I would prefer to list each version under the release where it was
removed, like below. Partly so we don't keep old ones forever (jruby was
removed in 2016, etc) - partly because this file is useful for figuring
out when things happened (especially when dirs are removed, because "cvs
log" is not very good at finding them, but also easier than looking at
category Makefile cvs log). Also makes the RE easier to read.

Versions figured out using 'cvs up -p -r OPENBSD_x_y devel/Makefile'
for the various releases.

Index: Makefile
===================================================================
RCS file: /cvs/ports/devel/quirks/Makefile,v
diff -u -p -r1.1664 Makefile
--- Makefile    24 Nov 2024 14:21:12 -0000      1.1664
+++ Makefile    26 Nov 2024 08:58:04 -0000
@@ -3,7 +3,7 @@ CATEGORIES =    devel databases
 DISTFILES =
 
 # API.rev
-PKGNAME =      quirks-7.71
+PKGNAME =      quirks-7.72
 PKG_ARCH =     *
 MAINTAINER =   Marc Espie <es...@openbsd.org>
 
Index: files/Quirks.pm
===================================================================
RCS file: /cvs/ports/devel/quirks/files/Quirks.pm,v
diff -u -p -r1.1676 Quirks.pm
--- files/Quirks.pm     24 Nov 2024 14:21:12 -0000      1.1676
+++ files/Quirks.pm     26 Nov 2024 08:58:04 -0000
@@ -771,6 +771,7 @@ setup_obsolete_reason(
        43 => 'upt-rubygems',
        3 => 'p5-VCP-autrijus',
 # 7.0
+       3 => qr{^ruby26-},
        3 => 'mailpile',
        7 => 'p5-Geo-GDAL',
        3 => 'gnome-latex',
@@ -979,6 +980,7 @@ setup_obsolete_reason(
        13 => 'py-scandir',
        3 => 'd-feet',
 # 7.2
+       3 => qr{^ruby27-},
        3 => 'gnome-documents',
        3 => 'lumail',
        3 => 'kalarmcal',
@@ -1080,6 +1082,7 @@ setup_obsolete_reason(
        3 => 'ogmrip',
        3 => 'shrip',
 # 7.4
+       3 => qr{^ruby30-},
        53 => 'compton',
        54 => 'depotdownloader',
        55 => 'residualvm',
@@ -1150,6 +1153,7 @@ setup_obsolete_reason(
        1 => 'proteus',
        1 => qr{^tryton},
 # 7.6
+       3 => qr{^ruby31-},
        5 => 'py3-pyls-black',
        5 => 'py3-python-language-server',
        5 => 'py3-python-jsonrpc-server',

Reply via email to