On Fri, Nov 22, 2024 at 03:41:14AM +0000, Jeremy Evans wrote: > On 11/21 09:31, Theo Buehler wrote: > > > Can someone put this diff into a bulk and see if there is any breakage? > > > I wouldn't expect any, since we ran the bulk in early October for > > > PostgreSQl 17.0, and this handles all of that fallout, but you never > > > know. > > > > This went well with no fallout. However, as pointed out by landry, it > > seems that 17.1 had an unintentional ABI break (struct layout change) > > affecting timescaledb, so it's probably better to update to 17.2 > > directly: > > > > https://www.postgresql.org/docs/release/17.2/ > > https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=6bfacd368 > > > > I don't think this warrants another bulk, although I haven't checked > > by diffing headers, etc. > > Here's the update to 17.2 (and postgresql-previous to 16.6). > > OKs for this and the updates to the following (which I've tested all > build with 17.2)? > > * postgresql-pllua > * repmgr > * pg_sqlite_fdw > * citus (mark BROKEN) > > I'm dropping the timescaledb change, since the in-tree timescaledb now > builds with PostgreSQL 17.2.
Just go ahead. ok tb