On Thu, Nov 07, 2024 at 08:26:06PM +0000, Mikolaj Kucharski wrote:
> On Thu, Nov 07, 2024 at 08:13:03PM +0000, Mikolaj Kucharski wrote:
> > On Thu, Nov 07, 2024 at 08:14:26PM +0100, Volker Schlecht wrote:
> > > Too early to ask for oks, but here's a diff to update lang/node to the
> > > new LTS
> > > version. node's v8 has now almost caught up with the one from chromium, so
> > > quite a few patches aren't needed anymore.
> > >
> > > I've also tried to handle the OpenSSL version such that we won't have to
> > > update
> > > the Makefile all over the place when switching versions, but I'm not yet
> > > sure
> > > if the way I did it is particularly nice, so feedback and opinions are
> > > very welcome.
> > >
> > > jca@, I *think* I got the riscv64 stuff right, but a test build would be
> > > great :-D
> >
> > Giving it a build with debug package enabled via
> >
> > https://marc.info/?l=openbsd-ports&m=173100797601439&w=2
> >
>
> FYI, it failed here with:
>
> ...
> In file included from ../src/js_native_api_v8.cc:7:
> In file included from ../src/js_native_api_v8.h:5:
> ../src/js_native_api_v8_internals.h:19:10: fatal error: 'gtest/gtest_prod.h'
> file not found
> #include "gtest/gtest_prod.h"
> ^~~~~~~~~~~~~~~~~~~~
> 1 error generated.
> gmake[1]: *** [libnode.target.mk:407:
> /usr/local/obj-ports/node-22.11.0/node-v22.11.0/out/Release/obj.target/libnode/src/js_native_api_v8.o]
> Error 1
> gmake[1]: *** Waiting for unfinished jobs....
> ...
>
Below diff on top of Volker's diff makes it compile here and
provides debug package:
diff -xCVS -ruN node/Makefile node-new/Makefile
--- node/Makefile Thu Nov 7 23:27:38 2024
+++ node-new/Makefile Thu Nov 7 20:32:28 2024
@@ -38,7 +38,8 @@
USE_GMAKE = Yes
-BUILD_DEPENDS = sysutils/flock
+BUILD_DEPENDS = sysutils/flock \
+ devel/gtest
RUN_DEPENDS = devel/gmake \
sysutils/flock
@@ -61,6 +62,8 @@
--shared-openssl \
--shared-openssl-libpath=${EOPENSSL_LIB} \
--shared-openssl-includes=${EOPENSSL_INC}
+
+DEBUG_PACKAGES = ${BUILD_PACKAGES}
CFLAGS += -idirafter ${LOCALBASE}/include
--
Regards,
Mikolaj
