On 2024/11/06 08:46, Rafael Sadowski wrote:
> On Fri Nov 01, 2024 at 06:32:06PM +0100, Landry Breuil wrote:
> > hi,
> > DISTNAME = QScintilla_src-${VERSION}
> > PKGNAME = py-qscintilla-${VERSION}
> > -REVISION = 0
> > +REVISION = 1
>
> Qt5 only REVISION bump? Othweise qt6 starts with p1.
That's not a problem, better to keep it simple
> > - x11/py-qt5${MODPY_FLAVOR}
> > -LIB_DEPENDS = editors/qscintilla=${VERSION}
> > + x11/py-${QTVER}${MODPY_FLAVOR}
> >
> > COMPILER = base-clang ports-gcc base-gcc
>
> Please move COMPILER above WANTLIB like you did it form qscintilla.
Listing base-gcc is quite optimistic :)
It doesn't matter much where COMPILER goes, though consistency between
similar ports makes sense.
> > +FULLPKGNAME = qscintilla-qt6-${VERSION}
> > +QTVER = qt6
> > +QTSUB = share/qt6
> > +MODULES += x11/qt6
> > +SHARED_LIBS = qscintilla2_qt6 0.0 # 15.0
>
> SHARED_LIBS should not be inside .if block. We don't do that in the
> other ports.
agreed.
