Le Mon, Nov 04, 2024 at 02:50:09PM +0000, Stuart Henderson a écrit : > lgtm.
havent looked at the actual diff, but should it apply as is to www/firefox-esr too ? > On 2024/11/04 14:31, Raf Czlonka wrote: > > On Mon, Nov 04, 2024 at 01:12:32PM GMT, Stuart Henderson wrote: > > > "though, but" is redundant - that line would sound better as "should > > > create > > > this directory, but it won't be available" > > > > Done. > > > > > "Check if it is enabled" feels a bit clunky, how about "Check that it's > > > enabled"? > > > > Yes, 'if it is' felt a bit clunky - all I wanted to do it to make it > > less broken ;^) > > > > > + REVISION bump needed. > > > > Aargh! I always forget! :^P > > > > Updated diff below. > > > > cvs server: Diffing www/mozilla-firefox > > Index: www/mozilla-firefox/Makefile > > =================================================================== > > RCS file: /cvs/ports/www/mozilla-firefox/Makefile,v > > diff -u -p -r1.608 Makefile > > --- www/mozilla-firefox/Makefile 29 Oct 2024 12:40:10 -0000 1.608 > > +++ www/mozilla-firefox/Makefile 4 Nov 2024 14:29:39 -0000 > > @@ -7,6 +7,7 @@ MOZILLA_VERSION = 132.0 > > MOZILLA_BRANCH = release > > MOZILLA_PROJECT = firefox > > MOZILLA_CODENAME = browser > > +REVISION = 0 > > > > WRKDIST = ${WRKDIR}/${MOZILLA_DIST}-${MOZILLA_DIST_VERSION:C/b[0-9]*//} > > HOMEPAGE = https://www.mozilla.org/firefox/ > > cvs server: Diffing www/mozilla-firefox/files > > cvs server: Diffing www/mozilla-firefox/patches > > cvs server: Diffing www/mozilla-firefox/pkg > > Index: www/mozilla-firefox/pkg/README > > =================================================================== > > RCS file: /cvs/ports/www/mozilla-firefox/pkg/README,v > > diff -u -p -r1.37 README > > --- www/mozilla-firefox/pkg/README 29 Oct 2024 12:40:10 -0000 1.37 > > +++ www/mozilla-firefox/pkg/README 4 Nov 2024 14:29:39 -0000 > > @@ -27,7 +27,7 @@ ${SYSCONFDIR}/${MOZILLA_PROJECT}/{unveil > > As unveil() can't show non-existing dirs, it is recommended to manually > > create ~/Downloads for files to be properly saved in this directory. > > > > -Starting ${MOZILLA_PROJECT} should create this dir though, but it wont be > > available > > +Starting ${MOZILLA_PROJECT} should create this directory, but it won't be > > available > > for downloads until it's restarted. > > > > 3rd-Party MIME Handlers > > @@ -119,7 +119,7 @@ device e.g.: > > > > # chown youruser /dev/video0 > > > > -Screen sharing needs shmget() which isnt available when pledge() is > > active, so > > +Screen sharing needs shmget() which isn't available when pledge() is > > active, so > > you will have to disable pledge for the main process. > > > > KerberosV support > > @@ -148,7 +148,7 @@ are enabled. > > > > Similarly, the rust-based WebRender compositor can be enabled by setting > > MOZ_WEBRENDER=1 in the environment, or by switching the about:config > > -gfx.webrender.enabled knob to true. Check it is enabled in the 'Features' > > +gfx.webrender.enabled knob to true. Check that it's enabled in the > > 'Features' > > section of about:support. For this feature, WebGL2 is necessary, so your > > hardware must support at least OpenGL 4. > > >