On 2024/10/30 10:09, Kirill A. Korinsky wrote: > ports@, > > Here the same archive with deps and updated version for wapiti diff which > includes regenerated PLIST to avoid merge conflicts which was noticed by tb@
Looking at the deps. devel/py-aiocache: - this looks like a better HOMEPAGE https://aiocache.aio-libs.org/ - it's not required but for pypi things I like to add a comment with a link to a useful upstream development page where possible, e.g. for this https://github.com/aio-libs/aiocache devel/py-prance: - the comment "# Dependencies" doesn't add anything of value ;) - "tests need network access" - I typically would not disable tests for this, but add a comment so somebody coming to the port knows what to expect. (if network access is available most fetches are 404'ing anyway..) "pypi artifact has missed tests/OpenAPI-Specification, so some tests fail" - again I think not a reason to disable tests, they don't need to all pass. someone updating the port can run tests, update, run tests again, and compare differences - that's still useful. so, I would keep the comments but drop NO_TEST. devel/py-structlog: - rather than patching to set every test in the file to skip, I suggest: MODPY_PYTEST_ARGS=--ignore tests/test_packaging.py tests/test_packaging.py security/py-krb5: - LIB_DEPENDS without WANTLIB is not valid. check-lib-depends doesn't handle libs in subdirs properly; you want "WANTLIB=heimdal/lib/krb5" for this www/py-browser-cookie3: - I added cryptodomex, please change the dep and kill the patches Those are OK sthen with the above changes. The other deps are OK sthen as-is. I haven't tested wapiti itself yet. Are the dep changes (to remove ==$VERSION) in pyproject.yaml actually needed? IIRC setuptools doesn't actually check versions from pyproject.yaml only from its other files. It would be better to avoid that big block of patches (which will break for most updates) if possible.
