On 2024/10/01 17:10, Stuart Henderson wrote: > On 2024/10/01 16:59, Bjorn Ketelaars wrote: > > Passes all tests and works with borgbackup-1.4 and 2.0. There are a > > couple of other consumers that seemingly are happy with this update, > > though this has not been tested thoroughly: > > > > databases/py-influxdb,python3 > > devel/py-buildbot/buildbot > > devel/py-buildslave > > editors/py-neovim > > editors/py-neovim,python3 > > net/synapse > > security/mitmproxy > > sysutils/salt > > textproc/calibre > > > > [0] https://github.com/msgpack/msgpack-python/releases/tag/v1.1.0. > > [1] > > https://github.com/msgpack/msgpack-python/commit/3e9a2a7419714c294be0590aab24f2dc040581f5 > > > > Comments / OK? > > Mostly looks good but the only one of those that I use is borgbackup so > I won't be very useful for additional testing. > > One nit, https://github.com/msgpack/msgpack-python/pull/610 removes > the build dep on cython, they're just using pregenerated .c files now > and they aren't rebuilt even if cython is present, so I think better > to remove the BDEP. > > > +Index: pyproject.toml > > +--- pyproject.toml.orig > > ++++ pyproject.toml > > +@@ -1,5 +1,5 @@ > > + [build-system] > > +-requires = ["setuptools >= 69.5.1"] > > ++requires = ["setuptools"] > > btw I tried an update to setuptools-75.1.0 in bulk which went rather poorly. > I'm trying 69.5.1 in my next one.
We now have 69.5.1 so this patch can be removed. (As can sysutils/borgbackup/1.4/patches/patch-pyproject_toml as we now have the expected Cython).
