Hi,
On Sat, Oct 05, 2024 at 01:16:25AM +0000, Lucas Raab wrote:
> Hello,
>
> Here's an update for sqlitebrowser that's worked fine with light testing
> via the sqlports database. Other tests or comments on the patch?
>
> changelog: https://github.com/sqlitebrowser/sqlitebrowser/releases/tag/v3.13.0
I tested it and looked at the diff, looks good to me. OK caspar@
Regarding the patch, I have one comment below.
>
> Thanks,
> Lucas
> diff refs/heads/master refs/heads/sqlitebrowser
> commit - 2548567bbb29861af9e107eff264e682a2a317a7
> commit + fad286d25aa3188d235c81d6d812ad5d28f66e59
> blob - 5d9c3e68b0e2bb1f8b2711e6cb6c71ff0877b4e1
> blob + 455af2f62523912c6d50b61fb8fb7f71420ffce0
> --- databases/sqlitebrowser/Makefile
> +++ databases/sqlitebrowser/Makefile
> @@ -2,8 +2,7 @@ COMMENT = graphical interface to sqlite databases
>
> GH_ACCOUNT = sqlitebrowser
> GH_PROJECT = sqlitebrowser
> -GH_TAGNAME = v3.12.2
> -REVISION = 0
> +GH_TAGNAME = v3.13.0
>
> CATEGORIES = databases x11
>
> blob - bc3b90d45ca6c8edec0705e9637d381aad052a3c
> blob + 7aacaa25f19ea44208f3de83c42ffc3c81339194
> --- databases/sqlitebrowser/distinfo
> +++ databases/sqlitebrowser/distinfo
> @@ -1,2 +1,2 @@
> -SHA256 (sqlitebrowser-3.12.2.tar.gz) =
> ZF+Y045dEopEnpPOvwPIBw+erNLRaxDkM6eB1UqdR4o=
> -SIZE (sqlitebrowser-3.12.2.tar.gz) = 3990817
> +SHA256 (sqlitebrowser-3.13.0.tar.gz) =
> /FasUcoo3Q4tBld1wDeVW3lel93J9mZt5PYvoRQlOCw=
> +SIZE (sqlitebrowser-3.13.0.tar.gz) = 4901507
> blob - /dev/null
> blob + 7cbfcc523fae623bdd7f45eea0b20f209541a289 (mode 644)
> --- /dev/null
> +++ databases/sqlitebrowser/patches/patch-CMakeLists_txt
> @@ -0,0 +1,14 @@
> +Index: CMakeLists.txt
> +--- CMakeLists.txt.orig
> ++++ CMakeLists.txt
> +@@ -517,10 +517,6 @@ if((NOT WIN32 AND NOT APPLE) OR MINGW)
> + )
> + endif()
> +
> +-if(UNIX)
> +- target_link_libraries(${PROJECT_NAME} dl)
> +-endif()
> +-
I was wondering if the "if(UNIX)" can become something like
"if(UNIX AND NOT OPENBSD)" and that the patch can then be upstreamed,
but I don't think it is a big deal.
> + if(ENABLE_TESTING)
> + add_subdirectory(src/tests)
> + endif()
