On 2024/08/02 00:02, Jag Talon wrote: > Aside from bumping the version, I also made patches to switch out > strcat/strcpy/strcmp/sprintf where I can as recommended by > https://www.openbsd.org/faq/ports/guide.html
hmm, we generally don't do that in ports. patches like that are quite invasive and hard to handle when updating, so if done at all are better off going upstream rather than being done in ports. (also we've had bugs introduced in ports before, sometimes quite nasty, in sprintf/etc conversion patches). that point in guide.html specifically refers to network servers (though for a network server, seeing loads of unsafe string functions would more likely be a reason not to have it in ports at all rather than to patch it). the rest looks alright but I'd orefer to drop the string patches.
