On Wed, 2024-07-24 at 12:36 +0100, Stuart Henderson wrote:
> If you're sending out diffs for things like this, please don't make
> unnecessary changes to the port. So in this case it would be the
> additional RDEP, the post-install stages, and file additions.
> Layout changes in the Makefile just make it hard to review (and
> usually when a port has a maintainer, they have already done the
> formatting in the way which they prefer).
>
> > diff -N files/pcbasic.png
> > Binary files /dev/null and pcbasic.png differ
>
> Stuffing binary files in the ports tree is not ideal. It would be
> better to fetch as a supplementary distfile if possible.
> It would look something like: setting SITES.icon, DISTFILES.icon,
> EXTRACT_ONLY=${GH_DISTFILE}, and copying from ${FULLDISTDIR}
> rather than ${FILESDIR}.
Ah you're right there are too many changes in here let me rework the
patch and also figure out how to pull the .png file instead.
Thank you!
--
he/him
jagtalon.net
weirder.earth/@jag
