On Tue, Jul 09, 2024 at 07:20:35PM +0200, Matthias Schmidt wrote:
> Hi Caspar,
> 
> * Caspar Schutijser wrote:
> > Hi Matthias,
> > 
> > On Mon, Jul 08, 2024 at 07:54:09PM +0200, Matthias Schmidt wrote:
> > > Hi Caspar,
> > > 
> > > * Caspar Schutijser wrote:
> > > > Hi,
> > > > 
> > > > I found the following piece of diff while I was reading through
> > > > the diff between 13.0.16 and 13.5.
> > > > 
> > > > $ git diff 
> > > > tor-browser-115.12.0esr-13.0-1-build1..tor-browser-115.12.0esr-13.5-1-build3
> > > > from https://gitlab.torproject.org/tpo/applications/tor-browser.git:
> > > > diff --git a/mozconfig-linux-x86_64 b/mozconfig-linux-x86_64
> > > > index 06cf6e75b14f..7d96d5aaa734 100644
> > > > --- a/mozconfig-linux-x86_64
> > > > +++ b/mozconfig-linux-x86_64
> > > > @@ -1,9 +1,13 @@
> > > >  . $topsrcdir/browser/config/mozconfigs/tor-browser
> > > >  
> > > > -ac_add_options --enable-default-toolkit=cairo-gtk3
> > > > +# Moz switched to lld for all Linux targets in Bug 1839739.
> > > > +ac_add_options --enable-linker=lld
> > > >  
> > > >  ac_add_options --disable-strip
> > > >  ac_add_options --disable-install-strip
> > > >  
> > > > 
> > > > In the diff below I reverted that part. Warning: I have not
> > > > build-tested it myself yet, nor have I looked into what it is supposed
> > > > to do exactly (will do that later).
> > > > 
> > > > Is it possible for you to test diffs? If so, can you try the diff below
> > > > and report back?
> > > 
> > > Sorry for the late response.  I've never build the Tor Browser before, I
> > > can build up something next weekend.  Also happy to try any package that
> > > you can build up before that.
> > 
> > I built a package and I put it here:
> > https://temp.schutijser.com/~caspar/tb-browser-13.5p0.tgz
> > 
> > Built on
> > kern.version=OpenBSD 7.5-current (GENERIC.MP) #162: Mon Jul  1 02:13:07 MDT 
> > 2024
> >     dera...@amd64.openbsd.org:/usr/src/sys/arch/amd64/compile/GENERIC.MP
> > , I hope that's recent enough.
> > 
> > You can probably install it with something like
> > # pkg_add -Dunsigned ./tb-browser-13.5p0.tgz
> > 
> > Let me know how it goes!
> 
> I can confirm that your package fixes the problem I saw.  Thanks a lot
> for figuring it out and providing a package for me to test!

Okay, good to know. I committed this now. I'm not yet sure why this
actually works but I'll figure that out later.

Thanks!

Caspar

> 
> Cheers
> 
>       Matthias

Reply via email to