On 20/06/2024 12:35, Stuart Henderson wrote:
> On 2024/06/16 12:40, Fabien ROMANO wrote:
>> make install works.
>> First time on the game, played some minutes, this game is really nice.
>>
>> What about those tools/.py files portcheck complain about ?
>> pkg_info -L wesnoth | grep '.py$'
>> /usr/local/share/wesnoth/data/tools/addon_manager/*
>> /usr/local/share/wesnoth/data/tools/expand-terrain-macros.py
>> /usr/local/share/wesnoth/data/tools/hexometer.py
>> /usr/local/share/wesnoth/data/tools/pywmlx/*
>> /usr/local/share/wesnoth/data/tools/terrain2wiki.py
>> /usr/local/share/wesnoth/data/tools/unit_tree/*
>> /usr/local/share/wesnoth/data/tools/wesnoth/*
>>
>> I have a diff to add lang/python (MODPY_COMPILEALL) if you want.
>
> No pyc files for those please. They are scripts for running separately
> ("#!/usr/bin/env python3" lines and executable). pyc files are just used
> for files which are imported as Python modules (usually in a directory
> tree with __init__.py files).
I'm confused, was thinking it is used for any .py files to speed up execution on
next run (not only module import). Still there are modules bundled in those
tools.
I have no idea what those tools are used for and the port does not have direct
depends on python so, in this case, performance do not matter I guess.
>
> portcheck's checks are not particularly sophisticated.
>
Well, sometimes it is better to keep it stupid.
I guess this one is better as is (from my pov ksh isn't elegant neither easy).
Perhapsd a knob like PORTROACH could be added to mute some checks on purpose ?
# some tools provided are written in python but not needed to run the game
PORTCHECK_DISABLE = python
How many knobs, is it only a few false negative checks ... don't know.
Even a simple knob like this could be tricky to implement in ksh.
